Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh clone has out of date snapshots #3216

Closed
kentcdodds opened this issue Mar 28, 2017 · 5 comments
Closed

Fresh clone has out of date snapshots #3216

kentcdodds opened this issue Mar 28, 2017 · 5 comments

Comments

@kentcdodds
Copy link
Contributor

After following the instructions in CONTRIBUTING.md, on a fresh clone of master, I'm getting outdated snapshots:

Summary of all failing tests
 FAIL  integration_tests/__tests__/failures-test.js (13.269s)
  ● throwing not Error objects

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 4.
    
    - Snapshot
    + Received
    
    @@ -6,35 +6,39 @@
         
         Expected value to be truthy, instead received
           false
           
           at Object.throws (__tests__/assertion-count-test.js:14:17)
    +      at process._tickCallback (internal/process/next_tick.js:103:7)
     
       ● .assertions() › throws
     
         expect.assertions(2)
         
         Expected two assertions to be called but only received one assertion call.
           
           at addAssertionErrors (../../packages/jest-jasmine2/build/setup-jest-globals.js:56:21)
    +      at process._tickCallback (internal/process/next_tick.js:103:7)
     
       ● .assertions() › throws on redeclare of assertion count
     
         expect(received).toBeTruthy()
         
         Expected value to be truthy, instead received
           false
           
           at Object.redeclare (__tests__/assertion-count-test.js:18:17)
    +      at process._tickCallback (internal/process/next_tick.js:103:7)
     
       ● .assertions() › throws on assertion
     
         expect.assertions(0)
         
         Expected zero assertions to be called but only received one assertion call.
           
           at addAssertionErrors (../../packages/jest-jasmine2/build/setup-jest-globals.js:56:21)
    +      at process._tickCallback (internal/process/next_tick.js:103:7)
     
       .assertions()
         ✕ throws
         ✕ throws on redeclare of assertion count
         ✕ throws on assertion
      
      at Object.<anonymous>.test (integration_tests/__tests__/failures-test.js:29:34)
      at process._tickCallback (internal/process/next_tick.js:103:7)


Snapshot Summary
 › 1 snapshot test failed in 1 test suite. Inspect your code changes or run with `npm run jest -- -u` to update them.

Test Suites: 1 failed, 128 passed, 129 total
Tests:       1 failed, 1288 passed, 1289 total
Snapshots:   1 failed, 623 passed, 624 total
Time:        82.159s, estimated 85s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

Thought you ought to know :)

@thymikee
Copy link
Collaborator

Yeah, I bumped into it lately, but it doesn't show up on neither of our CIs, wonder why.

@cpojer
Copy link
Member

cpojer commented Mar 28, 2017

That's odd. Which version of node is this?

@thymikee
Copy link
Collaborator

All versions we support :(

@aaronabramov
Copy link
Contributor

#3222 that should fix it. had the same issue locally, but both CIs passed just fine :/

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants