Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: use cpu limit for maxWorker, not cpu cores length #12993

Closed
Diokuz opened this issue Jul 6, 2022 · 4 comments
Closed

[Feature]: use cpu limit for maxWorker, not cpu cores length #12993

Diokuz opened this issue Jul 6, 2022 · 4 comments

Comments

@Diokuz
Copy link
Contributor

Diokuz commented Jul 6, 2022

πŸš€ Feature Proposal

There is a problem with jest in docker with cpu limits nodejs/node#28762

Motivation

nodejs/node#28762 ← this problem leads to very long (or even never) task completion.

Example

There are three options could be done:

  1. Use cpu limit (e.g. https://github.com/xiaoxiaojx/get_cpus_length) to setup the default value of maxWorkers
  2. Use --runInBand by default when process.env.CI is defined
  3. Make it possible to change maxWorkers via env, e.g.

JEST_MAX_WORKERS=3 npx jest

Pitch

Because you provide the default value of https://jestjs.io/docs/cli#--maxworkersnumstring

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as completed Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant