-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watcher failing to run on latest create-react-app (0.8.3) #41
Comments
interesting, so I've started looking into create-react support again now that we're at 2.x and sharing Jest code. It looks like it will register the project still ( and open ) but doesn't do any of the dots. My guess is that this is the new babel AST generate which isn't handling JSX (there's not a |
Hello, I'm not using CRA nor scripts but a setup with .babelrc and package.json jest section. The tests run in CLI and via this plugin in OUTPUT but I don't see dots, nearly identical to your screenshot. Can I do something to help on this ? |
I've seen some instability there around the babelrc parsing/finding - can you run the command |
I see other errors, jsx transformation does not work.
|
interesting, this sounds like your babelrc isn't being found, any chance you can clone this repo and run it and look at values inside |
I got the same error as @kroniak using fresh install of CRA 0.8.5. I noticed that CRA 0.8.5 is still using [email protected], which doesn't have jest-editor-support, because it was only introduced in 18.0.0. As a workaround, I manually updated jest to 18.0.0, and the test runner worked as expected. Of course, this is not optimal, but is at most a temporary workaround until CRA releases 0.9.0, which updates jest to 18.1.0 as of now. The only alternative I can see until then would be to rollback vscode-jest to support 17.0.2, or otherwise check for various versions of jest and handle accordingly? |
jest-editor-support comes with the vscode-extension rather than being installed through NPM, so it shouldn't be an issue to WRT coming from Jest in your node_modules. I wonder if we just accidentally broke jest 17 support somehow? |
That's possible, since jest 17 doesn't even use jest-editor-support, so any logic written with jest-editor-support in mind and as a dependency potentially ignores how jest worked before 18. |
I just installed the latest create-react-app and I can no longer get the watcher to run. I'm currently getting the following error in vscode:
All the tests are marked with empty green circles and indicate that tests haven't been run even though they have been.
The text was updated successfully, but these errors were encountered: