Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove snapshot processor and flat/snapshot config #1532

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 23, 2024

I'm pretty sure this isn't actually needed especially in ESLint v9 - we can always add it back (or something different) in a minor version

Resolves #292

BREAKING CHANGE: removed unneeded snapshot processor and flat/snapshot config

@G-Rath G-Rath requested a review from SimenB March 23, 2024 19:01
BREAKING CHANGE: removed `snapshot` processor and `flat/snapshot` config
@G-Rath G-Rath force-pushed the remove-snapshot-postprocessor branch from e870840 to 5921d9b Compare March 23, 2024 19:19
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 👍 as you say, easy enough to add back if it's needed.

Include some "as it's not needed" in the deprecation message? might encourage people to say "it actually is"?

@G-Rath G-Rath merged commit 98087f9 into next Mar 27, 2024
30 checks passed
@G-Rath G-Rath deleted the remove-snapshot-postprocessor branch March 27, 2024 18:02
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
# [28.0.0-next.5](v28.0.0-next.4...v28.0.0-next.5) (2024-03-27)

### Features

* remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9))

### BREAKING CHANGES

* removed unneeded `snapshot` processor and `flat/snapshot` config
Copy link

🎉 This PR is included in version 28.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 6, 2024
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06)

### Bug Fixes

* allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167))
* drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388))
* **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))

### Features

* drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355))
* drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580))
* remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8))
* remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9))
* upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd))

### BREAKING CHANGES

* Node v19 is no longer supported
* removed unneeded `snapshot` processor and `flat/snapshot` config
* dropped support for `@typescript-eslint/eslint-plugin` v5
* dropped support for Node v14
* removed `no-if` in favor of `no-conditional-in-test`
Copy link

github-actions bot commented Apr 6, 2024

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants