[max-expects] now considers expect.assertions(n) an expect call

[short-dsb]

The behavior in 26.8.1 changed from 26.7.0 to include expect.assertions when counting expect calls. This seems at odds with the purpose of expect.assertions to verify the number of intended expect calls. In 26.8.1, this means either dropping the verification or dropping a different expect, neither of which seem ideal.

My suggestions (in order of personal preference):

• Restore the behavior present in 26.7.0 and ignore expect.assertions calls when counting max-expects.
• Provide an option to restore the previous behavior, e.g., ignoreExpectAssertions: boolean.
• Update the documentation and tests to demonstrate the new behavior.

Thanks for your time and consideration. 🙂

[G-Rath]

Yup that's the same sort of thing as #1186 - we shouldn't count expect.<member>() as assertion calls.

[sir-gon]

This is a bit annoying...

All my 5-assertion tests are broken now, because is counting 6 (???).

This is my example explicitly says 5 assertions:

https://github.com/sir-gon/projecteuler-js/blob/main/src/helpers/bigNumbers.test.js#L44-L62

  it('bigSumMany examples', () => {
    expect.assertions(5);

    expect(bigSumMany(['2', '2'])).toBe('4');
    expect(bigSumMany(['123', '321'])).toBe('444');

    expect(bigSumMany(['2', '2', '2'])).toBe('6');

    expect(bigSumMany(['349', '854', '213', '543'])).toBe('1959');

    expect(
      bigSumMany([
        '12345678901234567890',
        '12345678901234567890',
        '12345678901234567890',
        '12345678901234567890'
      ])
    ).toBe('49382715604938271560');
  });

[G-Rath]

@sir-gon PRs are always welcome; otherwise I'll try and get this resolved myself tonight once I'm off work 🙂

[github-actions]

🎉 This issue has been resolved in version 26.8.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[short-dsb]

Thanks for the quick fix, @G-Rath! Your work is appreciated. 🙂