From 5d3ebcc420709a770e9d19de8d455fa97b55a231 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Wed, 31 Oct 2018 20:08:10 +0100 Subject: [PATCH] feat: update list of recommended rules BREAKING CHANGE: New rules added to the recommended config --- README.md | 12 ++++++------ index.js | 8 ++++++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 02ccd68c3..bdd94f2dd 100644 --- a/README.md +++ b/README.md @@ -83,16 +83,16 @@ for more information about extending configuration files. | [consistent-test-it][] | Enforce consistent test or it keyword | | ![fixable-green][] | | [expect-expect][] | Enforce assertion to be made in a test body | | | | [lowercase-name][] | Disallow capitalized test names | | ![fixable-green][] | -| [no-alias-methods][] | Disallow alias methods | | ![fixable-green][] | +| [no-alias-methods][] | Disallow alias methods | ![recommended][] | ![fixable-green][] | | [no-disabled-tests][] | Disallow disabled tests | ![recommended][] | | | [no-focused-tests][] | Disallow focused tests | ![recommended][] | | | [no-hooks][] | Disallow setup and teardown hooks | | | | [no-identical-title][] | Disallow identical titles | ![recommended][] | | -| [no-jasmine-globals][] | Disallow Jasmine globals | | ![fixable-yellow][] | +| [no-jasmine-globals][] | Disallow Jasmine globals | ![recommended][] | ![fixable-yellow][] | | [no-jest-import][] | Disallow importing `jest` | ![recommended][] | | | [no-large-snapshots][] | Disallow large snapshots | | | | [no-test-callback][] | Using a callback in asynchronous tests | | ![fixable-green][] | -| [no-test-prefixes][] | Disallow using `f` & `x` prefixes to define focused/skipped tests | | ![fixable-green][] | +| [no-test-prefixes][] | Disallow using `f` & `x` prefixes to define focused/skipped tests | ![recommended][] | ![fixable-green][] | | [no-test-return-statement][] | Disallow explicitly returning from tests | | | | [prefer-expect-assertions][] | Suggest using `expect.assertions()` OR `expect.hasAssertions()` | | | | [prefer-spy-on][] | Suggest using `jest.spyOn()` | | ![fixable-green][] | @@ -100,11 +100,11 @@ for more information about extending configuration files. | [prefer-to-be-null][] | Suggest using `toBeNull()` | | ![fixable-green][] | | [prefer-to-be-undefined][] | Suggest using `toBeUndefined()` | | ![fixable-green][] | | [prefer-to-contain][] | Suggest using `toContain()` | | ![fixable-green][] | -| [prefer-to-have-length][] | Suggest using `toHaveLength()` | ![recommended][] | ![fixable-green][] | +| [prefer-to-have-length][] | Suggest using `toHaveLength()` | | ![fixable-green][] | | [prefer-inline-snapshots][] | Suggest using `toMatchInlineSnapshot()` | | ![fixable-green][] | | [require-tothrow-message][] | Require that `toThrow()` and `toThrowError` includes a message | | | -| [valid-describe][] | Enforce valid `describe()` callback | | | -| [valid-expect-in-promise][] | Enforce having return statement when testing with promises | | | +| [valid-describe][] | Enforce valid `describe()` callback | ![recommended][] | | +| [valid-expect-in-promise][] | Enforce having return statement when testing with promises | ![recommended][] | | | [valid-expect][] | Enforce valid `expect()` usage | ![recommended][] | | ## Credit diff --git a/index.js b/index.js index 63fd70c42..8de1c9abe 100644 --- a/index.js +++ b/index.js @@ -37,12 +37,16 @@ module.exports = { 'jest/globals': true, }, rules: { + 'jest/no-alias-methods': 'warn', 'jest/no-disabled-tests': 'warn', 'jest/no-focused-tests': 'error', 'jest/no-identical-title': 'error', - 'jest/no-jest-import': 'warn', - 'jest/prefer-to-have-length': 'warn', + 'jest/no-jest-import': 'error', + 'jest/no-jasmine-globals': 'warn', + 'jest/no-test-prefixes': 'error', + 'jest/valid-describe': 'error', 'jest/valid-expect': 'error', + 'jest/valid-expect-in-promise': 'error', }, }, },