fix: Correct pass custom properties into Input component. close #73

jessy1092 · Sep 6, 2016 · 610d8e9 · 610d8e9
1 parent 823c3b1
commit 610d8e9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/elements/input.js b/src/elements/input.js
@@ -11,7 +11,7 @@ const Basic = React.createClass({
 
   render: function () {
 
-    const { props: { children, placeholder, type, ...other } } = this;
+    const { props: { className, children, ...other } } = this;
 
     if (typeof children != 'undefined') {
       return (
@@ -21,10 +21,8 @@ const Basic = React.createClass({
       );
     } else {
       return (
-        <div {...other}>
-          <input
-            placeholder={placeholder}
-            type={type}/>
+        <div className={className}>
+          <input {...other}/>
         </div>
       )
     }

diff --git a/test/__tests__/elements/Input-test.js b/test/__tests__/elements/Input-test.js
@@ -86,6 +86,17 @@ describe('Input', () => {
     expect(ReactDOM.findDOMNode(input).getAttribute('type')).toMatch('text');
   });
 
+  it('should have value for button type', () => {
+
+    let instance = TestUtils.renderIntoDocument(
+      <Input type="button" value="Submit..."></Input>
+    );
+
+    let input = TestUtils.findRenderedDOMComponentWithTag(instance, 'input');
+
+    expect(ReactDOM.findDOMNode(input).getAttribute('value')).toMatch('Submit...');
+  });
+
   it('should display Input name', () => {
     let Component = (
       <Input></Input>