Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug logging options #130

Closed
jessesquires opened this issue Sep 25, 2024 · 0 comments · Fixed by #141
Closed

Debug logging options #130

jessesquires opened this issue Sep 25, 2024 · 0 comments · Fixed by #141
Labels
enhancement priority: high

Comments

@jessesquires
Copy link
Owner

jessesquires commented Sep 25, 2024 •
edited
Loading

To help diagnose issues that come up around view model state and collection view state, it would be nice to have some debug logging implemented.

Todo:

  • Add a new setting in CollectionViewDriverOptions called loggingEnabled, defaults to false.
  • Introduce a new Logger class to encapsulate all logic. We don't need log levels or anything fancy right now.
  • The Logger should be owned by CollectionViewDriver and receive the loggingEnabled flag. We can pass it through to the other objects if needed.

Things to log:

  • Log view model before and after applying a diff
  • Log various steps happening in DiffableDataSource
  • Anything else?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement debug logging for view model updates jessesquires/ReactiveCollectionsKit
1 participant
@jessesquires