Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Refactor JSQMessage object hierarchy? #602

Closed
jessesquires opened this issue Nov 6, 2014 · 1 comment
Closed

Refactor JSQMessage object hierarchy? #602

jessesquires opened this issue Nov 6, 2014 · 1 comment
Milestone

Comments

@jessesquires
Copy link
Owner

Investigate if JSQTextMessage and JSQMediaMessage are still necessary.

Might make sense to re-combine under JSQMessage.

@jessesquires jessesquires added this to the Release 6.0 milestone Nov 6, 2014
@jessesquires
Copy link
Owner Author

Because of the later addition of isMediaMessage, these 2 subclasses should be absorbed into the parent JSQMessage class.

This flattens our view hierarchy and removes ambiguity and data duplication. (e.g., should you check isMessageMessage or isKindOfClass:[JSQMediaMessage class]? )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant