Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

How about to support JSQPhotoMediaItem with url? #582

Closed
demonnico opened this issue Oct 27, 2014 · 2 comments
Closed

How about to support JSQPhotoMediaItem with url? #582

demonnico opened this issue Oct 27, 2014 · 2 comments

Comments

@demonnico
Copy link

Hi @jessesquires
I just read the code inside JSQPhotoMediaItem.m, if the image in JSQPhotoMediaItem could be download by url that'll be much more flexible in my opinion.

Thanks for your nice library.

@jessesquires
Copy link
Owner

Thanks @demon1105 !

It can be! See the comments in the docs about subclassing. The JSQPhotoMediaItem has the bare minimum needed to work with the library, thus it is extremely flexible.

See the discussion in #476, the thread is pretty long, but there are some comments on how to do this, as well as insight about the design of the library itself. Hope that helps!

@demonnico
Copy link
Author

@jessesquires
Yes, in fact I'd achieved it by subclassing, that's just my way to make it.
I'll send a RP after some improvements to make codes become more strong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants