Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter binding label #3968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Filter binding label #3968

wants to merge 1 commit into from
+50 −49

Commits on Oct 5, 2024

  1. Update filter bindings to display on screen 

    Update the controller (filter_controller.go) to set up the binding to be
didsplayed. Additionally, update the translations for the binding name
to be shorter, to make it more likely the text will fit at the bottom of
the screen. This also involved updating the keybindings_*.md files with
go generate ./...

The keybinding screen in particular (which is a filterable popup) seems
frustrating for users. In jesseduffield#3141, @kadaan suggested that perhaps the
keybindings page should display a message in the footer about the
presence of this option as a way to increase discoverability.

This change enables this binding displaying on _all_ filterable views.
I'm not sure if it's valuable to restrict this to just the keybinding
view.
    @VeeDeltaVee
    VeeDeltaVee committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c7bdf92 View commit details
    Browse the repository at this point in the history