New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring docker log args from within lazydocker #406

Open

jesseduffield wants to merge 1 commit into master from in-app-log-args-config

Owner

jesseduffield commented Nov 23, 2022 •

edited

Loading

Adds a new view which shows the current args for the docker logs.
When you press 'i' a menu appears that allows you to change any of the values.

It's not ideal having this new view take up three rows of cells by virtue of having a frame. I could:

make it frameless (looks a bit cluttered being on top of the bottom row)
replace the keybindings help text at the bottom right with this new content
find a way to put this inside the main view. This would be the best UI but also the most difficult to implement

TODO:

i18n
only show view when logs are being shown
get this to work with docker-compose commands which go through the CLI interface (either append as args or remove ability to configure beyond the base 'docker compose' part of the command)
persist values across sessions

jesseduffield mentioned this pull request

No logs from random containers after updating to 0.19.0 #391

Open


          allow configuring docker log args from within lazydocker

78d0ab6

jesseduffield force-pushed the in-app-log-args-config branch from 97f11ea to 78d0ab6 Compare

November 26, 2022 00:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet