Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jerryk55/manageiq
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 73f42d4b321dccdb1ba4a44f067784d36fda465e~
Choose a base ref
...
head repository: jerryk55/manageiq
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d2bf3c857ff1b8857b26b1d4fa426672dfadff3e
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 20, 2018

  1. Fail Cinder/Swift Ensures if Service not Present

    Return false for cinder and swift ensure calls if the
    service is not present.
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1458959
    
    Requires a fix to the Openstack provider as well although order
    of merges is irrelevant.
    jerryk55 committed Mar 20, 2018
    Copy the full SHA
    73f42d4 View commit details
  2. Further fixes and changes required for Test Failures

    In order to allow spec tests to pass the cloud_manager_spec must requires an authentication
    object for the openstack provider.
    
    Also further checks for validity in the refresh parser.
    jerryk55 committed Mar 20, 2018
    Copy the full SHA
    f7dff4c View commit details
  3. Remove Extra Nil Check

    Review comments pointed out the nil check was extraneous.
    jerryk55 committed Mar 20, 2018
    Copy the full SHA
    976ea5e View commit details
  4. Fix typo in Safe Navigation Operator

    Typo in safe nav operator - "&" -after the "." instead of before
    caused an error.
    
    Not really needed on the first class so made it match with the swift refresh_parser.
    jerryk55 committed Mar 20, 2018
    Copy the full SHA
    d2bf3c8 View commit details
Loading