Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control over theming via config #53

Closed
DimitarChristoff opened this issue Jul 23, 2012 · 2 comments
Closed

control over theming via config #53

DimitarChristoff opened this issue Jul 23, 2012 · 2 comments

Comments

@DimitarChristoff
Copy link

Proposed change that will allow greater theming options.

.documentup.json

{
    "header": "docs/header.html",
    "footer": "docs/footer.html"
}

when supplied, use the files to produce the document.head and a superfluous code block before the end of the body tag of the document, overriding everything normally dispatched from the server.

an alternative syntax would be like this:

{ 
    "env": {
        "stylesheets": ["style1.css", "http://somedomain.com/style2.css"],
        "javascript": [
            "https://ajax.googleapis.com/ajax/libs/mootools/1.4.5/mootools-yui-compressed.js", 
            "js/docsDependencies.js", 
            "js/docs.js"
        ]
    }
}

used through iteration of env keys and injection in the head or bottom of the document.

Either way, it means you don't need to support themes and do ones that people don't like or want to change - a few out of the box will do and for everyone else, control methods will be supplied that can give whatever control is needed.

@jeromegn
Copy link
Owner

I like that.

At first I preferred option #1, but I think option #2 is simpler.

@jeromegn
Copy link
Owner

At the moment, the only option is to supply a theme (SCSS) in the correct directory (app/assets/stylesheets/themes/) and use the theme option in the config.

Theming is a complicated beast. I might tackle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants