Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -wformat warnings on Windows #242

Open
jeroen opened this issue Oct 4, 2022 · 6 comments
Open

Fix -wformat warnings on Windows #242

jeroen opened this issue Oct 4, 2022 · 6 comments

Comments

@jeroen
Copy link
Owner

jeroen commented Oct 4, 2022

CRAN started enfocring -wformat on Windows, which revealed some printf bugs in mongo-c-driver.
See: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/mongolite-00check.html

@kevinAlbs

@kevinAlbs
Copy link
Contributor

Thank you for the heads up @jeroen. Filed https://jira.mongodb.org/browse/CDRIVER-4484

@jeroen
Copy link
Owner Author

jeroen commented Oct 5, 2022

Can you also have a look at these -Wstrict-prototype warnings (i.e. missing void for functions without parameters)? These are going be problematic for C23: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/mongolite-00check.html

@kevinAlbs
Copy link
Contributor

@jeroen is this blocking mongolite from being released on CRAN? That may help us determine how to schedule.

@jeroen
Copy link
Owner Author

jeroen commented Oct 11, 2022

We do need to fix these warnings if we want to push out a new release, But it's not super urgent because we don't have to do a mongolite release soon, there are no urgent problems afaik.

@eramongodb
Copy link

@jeroen Fixes have been merged in mongodb/mongo-c-driver#1120. Please let us know if this commit resolved the issues reported.

@jeroen
Copy link
Owner Author

jeroen commented Oct 13, 2022

Thanks! That looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants