Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid Accent Color not working in dark theme #273

Closed
ricaun opened this issue Aug 12, 2024 · 5 comments
Closed

DataGrid Accent Color not working in dark theme #273

ricaun opened this issue Aug 12, 2024 · 5 comments
Assignees
@Nice3point
Labels
improvements ✨ Improvements to an existing functionality user interface 🎨 Issues/PR for the UI package

Comments

@ricaun
Copy link
Contributor

ricaun commented Aug 12, 2024 •
edited
Loading

RevitLookup version

2025.0.8

Steps to reproduce

By default RevitLookup uses the windows color as the Accent Color.

When using the dark theme, that color brightness is changed to make a better contrast in the dark background.

In the DataGrid the Accent Color brightness is not updated like the others UI elements.

If the windows system color is a dark color is really hard to visualize the data in the RevitLookup.

The image show when using a Dark Blue. The box show the correct color and the wrong color apply in the DataGrid

image
@ricaun ricaun added bug 🐛 An unexpected issue that highlights incorrect behavior unverified ⌛ Needs more investigation to conclude it's an actual bug labels Aug 12, 2024
@Nice3point Nice3point added improvements ✨ Improvements to an existing functionality and removed unverified ⌛ Needs more investigation to conclude it's an actual bug bug 🐛 An unexpected issue that highlights incorrect behavior labels Aug 13, 2024
@Nice3point Nice3point moved this to 📋 Backlog in RevitLookup roadmap Sep 1, 2024
@Nice3point Nice3point self-assigned this Sep 1, 2024
@Nice3point Nice3point added the user interface 🎨 Issues/PR for the UI package label Sep 1, 2024
@Nice3point
Copy link
Collaborator

Fixed in the 2025.0.9 update. Color now synced with system

@github-project-automation github-project-automation bot moved this from Pre-release to ✅ Done in RevitLookup roadmap Sep 22, 2024
@ricaun
Copy link
Contributor Author

ricaun commented Sep 22, 2024

Fixed in the 2025.0.9 update. Color now synced with system

Great!

I noticed the Nothing to show and Waiting for events is black for some reason! That happen when RevitLookup is opened in dark theme.

image

@Nice3point
Copy link
Collaborator

Nice3point commented Sep 23, 2024 •
edited
Loading

@ricaun no problems if the background effects enabled, need to look into what's wrong with resources:

изображение

@ricaun
Copy link
Contributor Author

ricaun commented Sep 23, 2024

I test with all the background effects and when I open a new RevitLookup always shows the text in black. I don't know if the background works because my windows version is 10.0.19045.

image

@ricaun
Copy link
Contributor Author

ricaun commented Sep 23, 2024 •
edited
Loading

New Issue just in case. #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nice3point Nice3point

Labels
improvements ✨ Improvements to an existing functionality user interface 🎨 Issues/PR for the UI package
Projects
RevitLookup roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricaun @Nice3point