fix(2228): added transaction free deleteAndRelease() Method

[sodoardi]

fixes: #2228

[divine]

Duplicate #2180

[sodoardi]

Wow.. didn't see that, looked everywhere to find a solution 🤦‍♂️
How can we get one of the fixes published? Looks like the other fix is stuck since 3 months now

[sodoardi]

@divine any updates on how best to proceed? Close this PR and wait for the other one to be released or how do we plan on getting this bug fixed?

[divine]

@divine any updates on how best to proceed? Close this PR and wait for the other one to be released or how do we plan on getting this bug fixed?

Hello,

I will talk with @Smolevich today and let you know what we've decided.

Thanks!

[sodoardi]

I'll take a look this weekend

[divine]

I'll take a look this weekend

Any update?

Thanks!

[sodoardi]

I'll take a look this weekend

Any update?

Thanks!

@divine at least grant me the whole weekend 😁
@Smolevich I added a test calling directly to the Queue::deleteAndRelease() method, I hope thats how you meant it!

[codecov-commenter]

Codecov Report

Merging #2229 (0b8f99b) into master (753cfde) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2229      +/-   ##
============================================
+ Coverage     86.88%   86.91%   +0.02%     
- Complexity      664      665       +1     
============================================
  Files            33       33              
  Lines          1556     1559       +3     
============================================
+ Hits           1352     1355       +3     
  Misses          204      204              

Impacted Files	Coverage Δ	Complexity Δ
src/Queue/MongoQueue.php	100.00% <100.00%> (ø)	11.00 <1.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753cfde...0b8f99b. Read the comment docs.

[divine]

@divine at least grant me the whole weekend 😁

Sorry but this is an open-source, contributors vanishing sometimes without any reply... and it was urgent for you too so no waiting whole weekend 🤣

@Smolevich I added a test calling directly to the Queue::deleteAndRelease() method, I hope thats how you meant it!

I think he meant this part:

$this->assertEquals(0, $result['reserved']);
$this->assertNull($result['reserved_at']);
$this->assertEquals(
        Carbon::now()->addRealSeconds($delay)->getTimestamp(),
        $result['available_at']
);
$this->assertEquals(Carbon::now()->getTimestamp(), $result['created_at']);
$this->assertEquals($job->getRawBody(), $result['payload']);

Thanks!

[sodoardi]

@divine oh no, I hope nothing bad happens to them. Should I be worried about my safety? 🤣
I did some restructuring on the tests, hope that works out! I won't be able to check back until this evening though (european time)

[Smolevich]

Resolve merge conflicts

[divine]

@divine oh no, I hope nothing bad happens to them. Should I be worried about my safety? 🤣
I did some restructuring on the tests, hope that works out! I won't be able to check back until this evening though (european time)

Don't worry about your safety, we're just having a fun conversation, so I ruined fun now completely 😄.

I really don't know what happens with them, probably too busy and it just works 😮.

Anyways, thank you for your contribution!

Resolved