Add support for custom prefix #924
Open
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
approved these changes
Feb 25, 2025
jglick
reviewed
Feb 26, 2025
|
|
||
| @Test public void noPrefix() throws Throwable { | ||
| rr.noPrefix().startJenkins(); | ||
| assertThat(rr.getUrl().getPath(), emptyString()); |
There was a problem hiding this comment.
Should this not be equalTo("/")?
jglick
reviewed
Feb 26, 2025
| @@ -825,7 +859,7 @@ public URL getUrl() throws MalformedURLException { | |||
| if (port == 0) { | |||
| throw new IllegalStateException("This method must be called after calling #startJenkins."); | |||
| } | |||
| return new URL(https ? "https" : "http", host, port, "/jenkins/"); | |||
| return new URL(https ? "https" : "http", host, port, prefix == null ? "" : prefix + "/"); | |||
There was a problem hiding this comment.
Suggested change
| return new URL(https ? "https" : "http", host, port, prefix == null ? "" : prefix + "/"); | |
| return new URL(https ? "https" : "http", host, port, prefix == null ? "/" : prefix + "/"); |
jglick
reviewed
Feb 26, 2025
Comment on lines
+413
to
+416
| var sanitized = Util.fixEmpty(prefix); | ||
| if (sanitized == null) { | ||
| throw new IllegalStateException("Use noPrefix() to remove the prefix."); | ||
| } |
There was a problem hiding this comment.
To my mind it would be clearer to delete noPrefix and just let .withPrefix("") mean to request http://localhost:12345/ which would be consistent with .withPrefix("/xxx") meaning http://localhost:12345/xxx/. The root URL is always expected to end with a slash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #917
Testing done
Submitter checklist