Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly report the skipped status #114

Open
PhotoTeeborChoka opened this issue Feb 1, 2022 · 0 comments
Open

Properly report the skipped status #114

PhotoTeeborChoka opened this issue Feb 1, 2022 · 0 comments

Comments

@PhotoTeeborChoka
Copy link

PhotoTeeborChoka commented Feb 1, 2022

What feature do you want to see added?

Thank you for this amazing plugin.

Basic info

version: github-autostatus:3.6.2

Problem

Originally the plugin labeled skipped jobs as stage built successfully (as evidenced by the now likely obsolete issue #101 ). Currently the plugin does not notify about the jobs once skipped, resulting in Building stage with yellow dot. The current state is not viable for different reasons:

  • if improperly set in Github, permanently "active" job that never ends blocks CI
  • the message imparted on Github user is in contrast with the real state of the CI
  • the Github perceived state of CI is incorrect (e.g. as evidenced by the issues Select which stages to notify about #105)

Suggested change

  1. report the stage of skipped jobs as skipped in Github
  2. mark the skipped jobs as passed in Github
  3. Order the reported jobs in the same manner as they are ordered in the pipeline

Upstream changes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant