-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posting status to a measurement with exception message when exception is thrown out of node #104
Comments
I've been trying to figure out a better way to handle these for awhile. Originally I added the ability to log exceptions outside of the pipeline because we had a couple of scripts that did this, and I wanted to be able to get counts got particular errors. However, in our case, I wish I'd taking the approach that they were badly written scripts, as the exceptions could have happened inside a stage, they just didn't. Curious what would work for you. It seems clear that it should write to the Option 1: ignore exceptions that happen outside of a stage, and just write the |
I think that Option 2 would be the better way. It could allow to get the satats of such cases and fix them asap. |
That's the way I was leaning as well. I'll make that change. Thanks for reporting! |
Heyo, has this been already addressed? :) |
Hey @jeffpearce , |
The plugin generates a lot of junk when any command generates exception out of node construction. It is creating a measurement with an exception message instead of writing to
job
orstage
measurement.Steps to reproduce:
node() {...}
orstage() {...}
The text was updated successfully, but these errors were encountered: