From 5730890d059d949cad87447252f6ccf58418fc67 Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Tue, 19 Dec 2023 18:28:20 -0700
Subject: [PATCH] Use spotbugs plugin 4.8.2.0 with new exclusions

Preparing for future upgrade of the plugin parent pom
---
 pom.xml                         |  1 +
 src/spotbugs/excludesFilter.xml | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/pom.xml b/pom.xml
index 4b988e04ae..5b4d1af397 100644
--- a/pom.xml
+++ b/pom.xml
@@ -67,6 +67,7 @@
     <jenkins.version>2.401.3</jenkins.version>
     <jgit.version>6.8.0.202311291450-r</jgit.version>
     <spotbugs.effort>Max</spotbugs.effort>
+    <spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
     <spotbugs.threshold>Low</spotbugs.threshold>
     <spotless.check.skip>false</spotless.check.skip>
   </properties>
diff --git a/src/spotbugs/excludesFilter.xml b/src/spotbugs/excludesFilter.xml
index 3c497e952c..28ec06cf3e 100644
--- a/src/spotbugs/excludesFilter.xml
+++ b/src/spotbugs/excludesFilter.xml
@@ -4,6 +4,24 @@
     Exclusions in this section have been triaged and determined to be
     false positives.
   -->
+  <Match>
+    <!-- Jenkins plugins generally not vulnerable to Finalizer attacks -->
+    <Bug pattern="CT_CONSTRUCTOR_THROW" />
+    <Or>
+      <Class name="hudson.plugins.git.GitAPI" />
+      <Class name="org.jenkinsci.plugins.gitclient.JGitAPIImpl$FileRepositoryImpl" />
+      <Class name="org.jenkinsci.plugins.gitclient.trilead.TrileadSession$ProcessImpl" />
+    </Or>
+  </Match>
+  <Match>
+    <!-- These primitive attributes need to be public to preserve the API -->
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE" />
+    <Class name="hudson.plugins.git.Tag" />
+    <Or>
+      <Field name="commitMessage" />
+      <Field name="commitSHA1" />
+    </Or>
+  </Match>
   <Match>
     <!-- intentional and accepted that it is not restored -->
     <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />