Work for fixing credentials issues #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
DavidTanner
added a commit
that referenced
this pull request
Jun 26, 2015
Work for fixing credentials issues
| String path = serverUri.getPath(); | ||
| if (StringUtils.isEmpty(path)) { | ||
| path = "/"; | ||
| } | ||
| specifications.add(new PathSpecification(serverUri.getPath(), null, false)); |
There was a problem hiding this comment.
this didn't actually fix the issue - it's not using the new path you created.
I have a few other suggestions. I'll send a PR shortly.
ixdy
added a commit
to ixdy/ghprb-plugin
that referenced
this pull request
Jun 26, 2015
- Actually use the new path generated as a fix in jenkinsci#122 - Use URIRequirementBuilder instead of manually building a requirements list - Add logging around accessing credentials to debug failures, and give better error messages when something is wrong - General refactoring of a few methods to reduce code duplication
ixdy
added a commit
to ixdy/ghprb-plugin
that referenced
this pull request
Jun 26, 2015
- Actually use the new path generated as a fix in jenkinsci#122 - Use URIRequirementBuilder instead of manually building a requirements list - Add logging around accessing credentials to debug failures, and give better error messages when something is wrong - General refactoring of a few methods to reduce code duplication
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Work for fixing credentials issues
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
- Actually use the new path generated as a fix in jenkinsci#122 - Use URIRequirementBuilder instead of manually building a requirements list - Add logging around accessing credentials to debug failures, and give better error messages when something is wrong - General refactoring of a few methods to reduce code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #117, also fix #119
Also adds a permissions check for specified repos.