Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger based on GitHub label #210

Closed
ixdy opened this issue Oct 6, 2015 · 7 comments
Closed

trigger based on GitHub label #210

ixdy opened this issue Oct 6, 2015 · 7 comments

Comments

@ixdy
Copy link
Contributor

ixdy commented Oct 6, 2015

As the summary states: it'd be nice to be able to trigger builds only when a pull request has a particular label added. (This is less noisy than making a comment.)

@benpatterson
Copy link
Member

benpatterson commented Oct 9, 2016

Noting here that github webhooks do include events related to labels.

@IanVS
Copy link

IanVS commented Nov 22, 2016

Are you sure about that, @benpatterson? GitHub's api docs say that a pull_request event is sent on labeling and unlabeling, and in fact that is the behavior I see when I test.

For example, I'm seeing:

{ 
    "action": "labeled",
    ...
    "label": {
        "id": 65342042,
        "url": "https://api.github.com/repos/xxxxx",
        "name": "CI",
        "color": "006b75",
        "default": false
     },
    ...
}

However, to be really effective, I would think that Jenkins would also need to be able to remove the label when the test is finished, so that it can be re-added to kick off another build. Otherwise we would need to remove/readd the label to kick Jenkins (which isn't the end of the world either I suppose).

@benpatterson
Copy link
Member

@IanVS I was saying what you are saying: that events are sent when something is labeled. Sorry if I'm missing something here...

@IanVS
Copy link

IanVS commented Nov 22, 2016

Ah, sorry, in my mind I added a not between do and include 🙄

This would be a great feature to have. Any idea how much effort it would be to implement?

@benpatterson
Copy link
Member

Haha no problem @IanVS

It's hard for me to tell you how much effort it would take. We recently merged a blacklist for labels, so I'm optimistic some of that can be re-used. But the true juggernaut right now is resolving issue 352; that is holding up other work on my end. If you were to take this on yourself I'd be glad to review/merge when ready.

@jamesgoodhouse
Copy link

I'm curious if there is an update for this, or if anyone has found a work-around or possibly another plugin that allows building of pull requests upon changes to the labels?

@bjoernhaeuser
Copy link
Contributor

This will be done by #639, therefore closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants