Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to fix spotbugs identified issues #159

Open
willwh opened this issue Oct 25, 2019 · 0 comments
Open

Refactor to fix spotbugs identified issues #159

willwh opened this issue Oct 25, 2019 · 0 comments

Comments

@willwh
Copy link
Member

willwh commented Oct 25, 2019

Running mvn spotbugs:check against the plugin, there are a number of issues that we should likely address.

There is also a comment from @slide in Jenkins JIRA;

You may want to use req.bindJson rather than looking at the JSON data directly.
https://github.com/vipinsthename/environment-dashboard/blob/master/src/main/java/org/jenkinsci/plugins/environmentdashboard/DashboardBuilder.java#L342 and here https://github.com/vipinsthename/environment-dashboard/blob/master/src/main/java/org/jenkinsci/plugins/environmentdashboard/EnvDashboardView.java#L232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant