diff --git a/pom.xml b/pom.xml index cfb43b20..57d126a3 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ org.jenkins-ci.plugins plugin - 4.51 + 4.67 @@ -56,10 +56,10 @@ 999999-SNAPSHOT - 2.2 - 2.332.1 + 2.361.4 + jenkinsci/${project.artifactId}-plugin - false + High + + org.jenkins-ci.plugins + junit + 1.63 + + + org.jenkins-ci.plugins + matrix-project + 771.v574584b_39e60 + + + org.jenkins-ci.plugins + script-security + 1158.v7c1b_73a_69a_08 + + + org.jenkins-ci.plugins.workflow + workflow-support + 820.vd1a_6cc65ef33 + @@ -99,7 +124,7 @@ org.jenkins-ci.plugins ivy - ${ivy.plugin.version} + 2.2 true @@ -108,17 +133,6 @@ org.jenkins-ci.plugins ant test - - - - org.jenkins-ci - annotation-indexer - - - org.jenkins-ci - symbol-annotation - - @@ -130,7 +144,6 @@ org.jenkins-ci.plugins matrix-project - jar org.jenkins-ci.plugins @@ -139,7 +152,6 @@ org.hamcrest hamcrest - 2.2 test @@ -151,12 +163,6 @@ io.jenkins configuration-as-code test - - - org.apache.commons - commons-lang3 - - diff --git a/src/main/java/hudson/plugins/envfile/EnvFileBuildWrapper.java b/src/main/java/hudson/plugins/envfile/EnvFileBuildWrapper.java index 659964c1..ce575433 100644 --- a/src/main/java/hudson/plugins/envfile/EnvFileBuildWrapper.java +++ b/src/main/java/hudson/plugins/envfile/EnvFileBuildWrapper.java @@ -1,5 +1,6 @@ package hudson.plugins.envfile; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.Extension; import hudson.Launcher; import hudson.model.AbstractBuild; @@ -37,6 +38,7 @@ public Environment setUp(AbstractBuild build, Launcher launcher, BuildListener l @Extension public static final class DescriptorImpl extends BuildWrapperDescriptor { @Override + @SuppressFBWarnings(value = "NP_NONNULL_RETURN_VIOLATION", justification = "TODO needs triage") public String getDisplayName() { return null; } diff --git a/src/main/java/hudson/plugins/setenv/SetEnvBuildWrapper.java b/src/main/java/hudson/plugins/setenv/SetEnvBuildWrapper.java index 600b52e0..6ff754fa 100644 --- a/src/main/java/hudson/plugins/setenv/SetEnvBuildWrapper.java +++ b/src/main/java/hudson/plugins/setenv/SetEnvBuildWrapper.java @@ -1,5 +1,6 @@ package hudson.plugins.setenv; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.Extension; import hudson.Launcher; import hudson.model.AbstractBuild; @@ -46,6 +47,7 @@ public Environment setUp(AbstractBuild build, Launcher launcher, BuildListener l @Extension public static final class DescriptorImpl extends BuildWrapperDescriptor { @Override + @SuppressFBWarnings(value = "NP_NONNULL_RETURN_VIOLATION", justification = "TODO needs triage") public String getDisplayName() { return null; } diff --git a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordWrapper.java b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordWrapper.java index dc0ee887..a7b18d93 100644 --- a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordWrapper.java +++ b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordWrapper.java @@ -1,5 +1,6 @@ package org.jenkinsci.plugins.envinject; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.Extension; import hudson.Launcher; import hudson.model.AbstractBuild; @@ -37,6 +38,7 @@ public boolean isApplicable(AbstractProject item) { } @Override + @SuppressFBWarnings(value = "NP_NONNULL_RETURN_VIOLATION", justification = "TODO needs triage") public String getDisplayName() { return null; } diff --git a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java index a4b069fa..cfbbb712 100644 --- a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java +++ b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java @@ -2,6 +2,7 @@ import com.google.common.base.Function; import com.google.common.collect.Lists; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.Extension; import hudson.Launcher; import hudson.console.LineTransformationOutputStream; @@ -233,6 +234,7 @@ static class EnvInjectPasswordsOutputStream extends LineTransformationOutputStre } @Override + @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage") protected void eol(byte[] bytes, int len) throws IOException { String line = new String(bytes, 0, len); if (passwordsAsPattern != null) { diff --git a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectVarList.java b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectVarList.java index 79b38e15..23f1971f 100644 --- a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectVarList.java +++ b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectVarList.java @@ -1,5 +1,6 @@ package org.jenkinsci.plugins.envinject; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.model.Api; import org.kohsuke.stapler.StaplerRequest; import org.kohsuke.stapler.StaplerResponse; @@ -102,6 +103,7 @@ private void doExportHeaders(@NonNull StaplerRequest request, @NonNull StaplerRe } + @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage") private void writeTextResponse(@NonNull StaplerResponse response) throws IOException { response.setContentType("plain/text"); StringWriter stringWriter = new StringWriter(); @@ -111,6 +113,7 @@ private void writeTextResponse(@NonNull StaplerResponse response) throws IOExcep response.getOutputStream().write(stringWriter.toString().getBytes()); } + @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage") private void writeXmlResponse(@NonNull StaplerResponse response) throws IOException { response.setContentType("application/xml"); ServletOutputStream outputStream = response.getOutputStream(); @@ -121,6 +124,7 @@ private void writeXmlResponse(@NonNull StaplerResponse response) throws IOExcept outputStream.write("".getBytes()); } + @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage") private void writeJsonResponse(@NonNull StaplerResponse response) throws IOException { response.setContentType("application/json"); ServletOutputStream outputStream = response.getOutputStream(); diff --git a/src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java b/src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java index d700a026..44ced63b 100644 --- a/src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java +++ b/src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java @@ -1,7 +1,7 @@ package org.jenkinsci.plugins.envinject; -import com.gargoylesoftware.htmlunit.HttpMethod; -import com.gargoylesoftware.htmlunit.WebRequest; +import org.htmlunit.HttpMethod; +import org.htmlunit.WebRequest; import hudson.EnvVars; import hudson.model.*;