Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out plugins already installed #207

Closed
jimzucker opened this issue Feb 26, 2016 · 4 comments
Closed

Filter out plugins already installed #207

jimzucker opened this issue Feb 26, 2016 · 4 comments

Comments

@jimzucker
Copy link

When we pass in a list of plugins, it would be efficient if the list was filtered based on what is already installed. If the team is agrees this is a good idea I can take a shot at modifying the script.

jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 1, 2016
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 1, 2016
…d, creating a new pull request for this"

This reverts commit 02cc97a.
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 1, 2016
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 2, 2016
…-e back to ensure build failues if there are issues
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 8, 2016
…-e back to ensure build failues if there are issues, based on plugins packged in the jenkins.war file.
@jimzucker
Copy link
Author

Updated to base analysis on jenkins.war, test results:
Removing intermediate container 7f545b034f1a
Step 7 : RUN /usr/local/bin/plugins.sh /usr/share/jenkins/ref/plugins.txt
---> Running in f1606faa6f4a
... skipping already installed: ant:1.2
... skipping already installed: antisamy-markup-formatter:1.1
... skipping already installed: credentials:1.18
Downloading cucumber-testresult-plugin:0.8.2
... skipping already installed: cvs:2.11
... skipping already installed: external-monitor-job:1.4
Downloading git:2.4.0
Downloading git-client:1.19.0
... skipping already installed: javadoc:1.1
... skipping already installed: junit:1.2-beta-4
... skipping already installed: ldap:1.11
... skipping already installed: mailer:1.11
... skipping already installed: matrix-auth:1.1
... skipping already installed: matrix-project:1.4.1
... skipping already installed: maven-plugin:2.7.1
... skipping already installed: pam-auth:1.1
Downloading scm-api:1.0
... skipping already installed: script-security:1.13
... skipping already installed: ssh-credentials:1.10
... skipping already installed: ssh-slaves:1.9
... skipping already installed: subversion:1.54
... skipping already installed: translation:1.10
... skipping already installed: windows-slaves:1.0
---> 8da9a950147d
Removing intermediate container f1606faa6f4a
Step 8 : ADD jobs /var/jenkins_home/jobs

@jimzucker
Copy link
Author

@gmacario I added the use case you suggested on PR #219 when I tested I observed with the current implimentation you have restart the docker instance for the plugins to get copied from the /ref directory and restart jenkins to see them.

I see two choices(maybe you see more):

  1. I can print a messages explaining you have to restart docker for the changes to take effect
  2. We can install the plugins in a different manner /restart automatically..

I am thinking approach #1 is probably the way to go for right now..

Thoughts?

jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 10, 2016
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 10, 2016
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 10, 2016
…rt running at compile time in the docker file and also running with exec on an exisitng container
jimzucker pushed a commit to jimzucker/docker that referenced this issue Mar 16, 2016
@jimzucker
Copy link
Author

@gmacario - I implemented a warning the you have to restart the container and squished the commits.

gmacario pushed a commit to gmacario/jenkinsci-docker that referenced this issue Apr 4, 2016
gmacario pushed a commit to gmacario/jenkinsci-docker that referenced this issue Apr 4, 2016
jimzucker pushed a commit to jimzucker/docker that referenced this issue Apr 5, 2016
@carlossg
Copy link
Contributor

#219 is merged

fatihkilic pushed a commit to fatihkilic/docker that referenced this issue Apr 14, 2017
fatihkilic pushed a commit to fatihkilic/docker that referenced this issue Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants