[JEP-224] System read permissions

[res0nance]

Add JEP-224 system read support.

Screenshots show non logged in user with system read access

Screenshots

[oleg-nenashev]

Sounds about right. Will need a follow-up update for Manage permissions AFAICT.

[timja]

@aheritier

[aheritier]

@res0nance @oleg-nenashev @timja it looks good to me but I have a doubt for the "cleanup" action at the jobs level

cloudbees-disk-usage-simple-plugin/src/main/resources/com/cloudbees/simplediskusage/QuickDiskUsagePlugin/index.jelly

Line 60 in 79ba68d

<s:link href="clean/?job=${e.fullName}" post="true">run cleanup</s:link>

cloudbees-disk-usage-simple-plugin/src/main/java/com/cloudbees/simplediskusage/QuickDiskUsagePlugin.java

Line 142 in c83a9e4

public void doClean(StaplerRequest req, StaplerResponse res) throws IOException, ServletException {

We are forcing the logRotate (which is less useful now there is a global setting) but I am not sure about the permission to do it. With this change are we opening it to all people with a SYSTEM.READ access ?

[timja]

Reviewed that, I don't think there's an issue here.

The only action the user is taking is invoking a pre-configured log rotator, and forcing it to run now.
They can't modify anything, it's a similar case to allowing updating the update center cache in the plugin center.

[aheritier]

LGTM