Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39225] Improved (reverted) German translation of Branch(es) … #654

Merged
merged 2 commits into from
Dec 12, 2016
Merged

[JENKINS-39225] Improved (reverted) German translation of Branch(es) … #654

merged 2 commits into from
Dec 12, 2016

Conversation

svijee
Copy link
Contributor

@svijee svijee commented Dec 10, 2016

Description

See JENKINS-39225.

I've reverted the German translations of "Branch(es)" and "Pull-Request(s)". No one uses the words "Ableger" and/or "Integrationsanfrage" for those words. Both are highly confusing. And IMHO one should not simply translate common technical english words into German. (e.g. "Pipeline" isn't translated and that's good!)

Translations seems to be included in #556

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

…and Pull-Request(s)

@michaelneale
Copy link
Member

thanks @svijee - I will let @scherler and @daniel-beck - 2 native speakers review.

I need to check this doesn't upset the acceptance test - as it looks in a few places for some specific german translations to make sure the subsystem is working (easy enough to change the test if any of those translations change) - I think it just looks for the nue pipeline button or something.

cc @scherler

Looks like ATH is happy with this: https://ci.blueocean.io/job/ATH-Jenkinsfile/job/master/600/

@daniel-beck
Copy link
Member

I complained about these terms in #556 already but was ignored. Apparently what gets translated from English into Spanish must also be translated into German.

#556 (comment)
#556 (comment)
#556 (comment)

So a clear 👍 from me.


@svijee What's your opinion on Build/Ausführung?

@svijee
Copy link
Contributor Author

svijee commented Dec 12, 2016

@svijee What's your opinion on Build/Ausführung?

I would still prefer "Build" over "Ausführung". But as I didn't see that on the first attempt, it's not as bad as Integrationsanfrage/Ableger.

@scherler
Copy link
Collaborator

@svijee @daniel-beck do you really have no german translations for those words? Integrationsanfrage would explain a German from the 18th century what a pull request is. Not translating it is giving up our language. Anyway @svijee Buid is translated as it is in core jenkins (aka classic) where you find Ausführung.

@svijee @daniel-beck if you "have to" translate branch and pr into german what would it be?

@i386
Copy link
Contributor

i386 commented Dec 12, 2016

What does Github or Bitbucket use for their translation?

@svijee
Copy link
Contributor Author

svijee commented Dec 12, 2016

do you really have no german translations for those words?

No, everyone uses "pull-requests" and "branch". Some people use "Zweig" for "branch" which is the closest translation but definitely not "Ableger".

Integrationsanfrage would explain a German from the 18th century what a pull request is. Not translating it is giving up our language.

Well everyone who uses git (or other SCM) and Jenkins should know what commits/repository/branches/pull-requests are. This is highly confusing and IMHO one shouldn't translate common english technical words. This has not much to do with 'giving up our language' because these are technical words and not common german words.

Anyway @svijee Buid is translated as it is in core jenkins (aka classic) where you find Ausführung.

Classic jenkins uses "Build". The top-left menu on classic jenkins says "Build-Verlauf" and Build-Executors are "Build-Prozessor" and Build Queue is "Build Warteschlange". This should also be the translation in blue ocean.

What does Github or Bitbucket use for their translation?

@i386 GitHub and Bitbucket are not translated at all. I think we should take the git cli tool as a reference. There, they don't translate "branch", "request-pull", "commit" etc.

@michaelneale
Copy link
Member

I am fascinated by Germans from the 18th century talking about pull requests. I have a vivid mental image.

@svijee
Copy link
Contributor Author

svijee commented Dec 12, 2016

@michaelneale YMMD 😆

@scherler
Copy link
Collaborator

@svijee yeah could have sworn I took that from the core but looking at the classic UI I do not see it ATM. If you want to add that to this PR and I will merge it.

@michaelneale german is a bit like Chinese in the sense that using many old words to describe the new concept like "Datenverarbeitungsanlage" for computer. ;)

@svijee
Copy link
Contributor Author

svijee commented Dec 12, 2016

@svijee yeah could have sworn I took that from the core but looking at the classic UI I do not see it ATM. If you want to add that to this PR and I will merge it.

Thanks, done!

@michaelneale german is a bit like Chinese in the sense that using many old words to describe the new concept like "Datenverarbeitungsanlage" for computer. ;)

That would be rather 'Rechner'. ;)

@scherler scherler merged commit cb3cffc into jenkinsci:master Dec 12, 2016
@svijee svijee deleted the JENKINS-39225_de branch December 12, 2016 11:58
@daniel-beck
Copy link
Member

@scherler

do you really have no german translations for those words? … Not translating it is giving up our language

I remember the first computer science course in University. I was beyond confused by the terms Halde and Stapel. I've never heard or seen anyone use those terms for heap and stack before or since.

While perhaps admirable, you're not the Gesellschaft für deutsche Sprache. Go with what your users know and use. And they say Branch, Build, Pull-Request (adapted to German grammar only).

@michaelneale
Copy link
Member

Do you want me to sing the german national anthem to sooth your souls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants