From cd3c07c0997fe721d5ae8c8b705b175f23fa170f Mon Sep 17 00:00:00 2001 From: Tim <4141828+heisian@users.noreply.github.com> Date: Fri, 16 Aug 2019 11:31:30 -0700 Subject: [PATCH 1/2] Update README.md w/ note about installation on macOS Installing the project requires usage of JDK 1.8. --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 1d3978ef865..0bae69bf769 100644 --- a/README.md +++ b/README.md @@ -70,6 +70,8 @@ Builds all maven modules (run this the first time you check things out, at least $ mvn clean install ``` +**NOTE:** If you are using macOS, you must install JDK 1.8 or the installation will fail. The most recent versions of macOS come preinstalled with JDK 10. Please follow [this link](https://stackoverflow.com/questions/46513639/how-to-downgrade-java-from-9-to-8-on-a-macos-eclipse-is-not-running-with-java-9/48422257#48422257) for instructions. + For now, you'll need to skip the tests if __building on Windows__, so be sure to include the `-DskipTests` switch e.g. ``` From d2f17cf7c39d76c5b675da2b1fe030653641c629 Mon Sep 17 00:00:00 2001 From: Tim <4141828+heisian@users.noreply.github.com> Date: Fri, 16 Aug 2019 11:33:58 -0700 Subject: [PATCH 2/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0bae69bf769..0d3545bfbf1 100644 --- a/README.md +++ b/README.md @@ -70,7 +70,7 @@ Builds all maven modules (run this the first time you check things out, at least $ mvn clean install ``` -**NOTE:** If you are using macOS, you must install JDK 1.8 or the installation will fail. The most recent versions of macOS come preinstalled with JDK 10. Please follow [this link](https://stackoverflow.com/questions/46513639/how-to-downgrade-java-from-9-to-8-on-a-macos-eclipse-is-not-running-with-java-9/48422257#48422257) for instructions. +**NOTE:** If you are using macOS, you must install JDK 1.8 or the installation will fail (The most recent versions of macOS come preinstalled with JDK 10). Please follow [this link](https://stackoverflow.com/questions/46513639/how-to-downgrade-java-from-9-to-8-on-a-macos-eclipse-is-not-running-with-java-9/48422257#48422257) for instructions. For now, you'll need to skip the tests if __building on Windows__, so be sure to include the `-DskipTests` switch e.g.