Optimize ObjId2FullSidMap::extractObjectId #599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitoring of one of our Jenkins instances showed that
ObjId2FullSidMap::extractObjectId
was a major CPU hotspot.This PR attempts to make the code significantly faster.
Testing done
The change was tested with the newly created functional test (
ObjId2FullSidMapTest::testExtractObjectId
) and the newly created microbenchmark (ObjId2FullSidMapTest::testExtractObjectIdPerformance
).On my local machine the benchmark reported the following with the original code:
With the new code the benchmark reports:
So, this suggest that the new code is roughly 28 times faster than the previous one for typical input.
Submitter checklist