Add theme manager integration #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jenkinsci/dark-theme-plugin#439 and https://learn.microsoft.com/en-us/graph/toolkit/customize-components/style
Seems to look good enough, we could fully customise the theme to match the jenkins colours if required but this is less to maintain.
Requires https://github.com/jenkinsci/dark-theme-plugin/releases/tag/409.v1753a_3e30d12
Before:
After:
Testing done
Tested with new dark theme interactively on the system security page, see screenshots.