Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton controller is not respecting namespace's scope #6816

Closed
1 of 2 tasks
cdbkr opened this issue Feb 25, 2020 · 8 comments
Closed
1 of 2 tasks

Tekton controller is not respecting namespace's scope #6816

cdbkr opened this issue Feb 25, 2020 · 8 comments
Labels
area/tekton area/tekton indicates that the issue was reported against the Servereless Jenkins X Pipelines kind/bug Issue is a bug lifecycle/stale priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@cdbkr
Copy link

cdbkr commented Feb 25, 2020

Summary

At the moment Tekton Controller deployed in the Jenkins-x namespace is not scoped to the related namespace but it is watching over other Tekton resources in other namespaces too.

Steps to reproduce the behavior

Install Jenkins-x in 2 different namespaces

Expected behavior

Tekton controller is watching and reacting to Tekton CRDs in the same namespace only

Actual behavior

Tekton controller is reacting to Tekton CRDs deployed in other namespaces too (duplicating build pods)

Jx version

The output of jx version is:

NAME               VERSION
jx                 2.0.1202
Kubernetes cluster v1.14.10+IKS
kubectl            v1.15.2
helm client        Client: v2.14.1+g5270352
git                2.20.1 (Apple Git-117)
Operating System   Mac OS X 10.14.6 build 18G87

Jenkins type

  • Serverless Jenkins X Pipelines (Tekton + Prow)
  • Classic Jenkins

Kubernetes cluster

v1.14.10+IKS - JX boot

Operating system / Environment

Mac OS

@abayer abayer added area/tekton area/tekton indicates that the issue was reported against the Servereless Jenkins X Pipelines kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 26, 2020
@abayer
Copy link
Contributor

abayer commented Feb 26, 2020

So this is tektoncd/pipeline#2111 - gonna see if I can fix it (and backport it to our Tekton 0.8.0 fork) later this week.

@fraenkel
Copy link

fraenkel commented Mar 3, 2020

@abayer I have a potential fix which I haven't tested. You might want to give it a go and see if it does in fact fix this issue.
fraenkel/pipeline@064045d

@abayer
Copy link
Contributor

abayer commented Mar 3, 2020

That feels right to me - mind opening a PR against Tekton? =)

@abayer
Copy link
Contributor

abayer commented Mar 6, 2020

I'm gonna try to backport this to our 0.8.0-derived weirdo of a branch soon - relevant (merged upstream) PR is tektoncd/pipeline#2144

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@cdbkr
Copy link
Author

cdbkr commented Jun 5, 2020

/remove-lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@abayer
Copy link
Contributor

abayer commented Sep 3, 2020

Oops, forgot to close this when I upgraded Tekton.

@abayer abayer closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tekton area/tekton indicates that the issue was reported against the Servereless Jenkins X Pipelines kind/bug Issue is a bug lifecycle/stale priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants