Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the PR title/body if rerun #646

Open
gounthar opened this issue Jan 15, 2025 · 2 comments
Open

Force the PR title/body if rerun #646

gounthar opened this issue Jan 15, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@gounthar
Copy link
Collaborator

gounthar commented Jan 15, 2025

What feature do you want to see added?

We've been running update campaigns for a while now, and some plugin maintainers have already reviewed and accepted our automatic PRs. However, some haven't reviewed or merged them, which was expected since the plugins we are targeting aren't as closely monitored as the most installed ones.

Whenever we relaunch a campaign on the same set of plugins, we force-push the same code, but it seems we don't modify the PR title and body. Between the campaigns, the text for the title and/or body may have changed because the project is evolving, and new JTE templates are being regularly updated.
Furthermore, some plugin maintainers gave some feedback (one of them being pretty harsh) about the PR body, so the PR body will evolve in order to satisfy most of the plugin maintainers.

That's why I propose that we consider changing the PR title and body when relaunching a campaign, provided the title and body haven't been edited since the PR was created.

Upstream changes

No response

Are you interested in contributing this feature?

No response

@jonesbusy jonesbusy added the good first issue Good for newcomers label Jan 16, 2025
@jonesbusy
Copy link
Collaborator

Makes sense definitely. Since we check a PR exists for a given repository and branch we could easily fetch the PR and update it's title and body.

Adding the good-first-issue tag

@gounthar
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants