Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub action #537

Open
jonesbusy opened this issue Dec 30, 2024 · 7 comments
Open

Implement GitHub action #537

jonesbusy opened this issue Dec 30, 2024 · 7 comments
Labels
good first issue Good for newcomers

Comments

@jonesbusy
Copy link
Collaborator

What feature do you want to see added?

  • action can be added on same repo and uses same version scheme
  • java based temurin 17
  • download jar via java
  • dry-run option as input
  • recipe as input
  • GH_TOKEN as auth (API and git)
  • against current repo (--plugin-path option ? Or do we need and option to run on current repo and not create fork ?
  • test against one plugin

Probably very similar to

https://github.com/jreleaser/release-action

Upstream changes

See if we need an option to apply changes on current repo and not perform forking

Are you interested in contributing this feature?

No response

@jonesbusy jonesbusy added the good first issue Good for newcomers label Dec 30, 2024
@morishima-senpai
Copy link

Hi, I would like to work on this issue:)

@nagu165
Copy link
Contributor

nagu165 commented Jan 10, 2025

Hello sir,
Are there any plugins that won't support temurin 21 yet or we can update to using 21 as it is also a LTS version?

Thank you.

@jonesbusy
Copy link
Collaborator Author

Many outdated plugin are not supporting yet Java 17 or 21. But I think the use case here is more about applying latest archetype changes on plugins. So I would expect the action/workflow to be installed on only active plugin.

The minimum Java version for Jenkins is 11 and 17 for recent LTS version.

So I would for for Java 17 to run plugin-modernizer action

@gounthar
Copy link
Collaborator

gounthar commented Jan 10, 2025

@nagu165 : I think the question is not whether plugins will support Java 21 or not, but let me clarify a few things first. Many plugins won’t support Temurin 21 yet; we’re not ready. Jenkins core has been supporting Java 21 for a while now, and we started a campaign last year to upgrade the most installed plugins to Java 21. However, there are still many plugins that aren’t ready for Java 21, which is why we're focusing on getting them to work with Java 17 first.

Our goal in addressing this issue is to create a GitHub Action that would launch the modernizer tool. Then, the infra team could add this GitHub Action to existing plugins by default, or we could propose it through a PR to encourage maintainers to add this GitHub Action.

@nagu165
Copy link
Contributor

nagu165 commented Jan 10, 2025

Many outdated plugin are not supporting yet Java 17 or 21. But I think the use case here is more about applying latest archetype changes on plugins. So I would expect the action/workflow to be installed on only active plugin.

The minimum Java version for Jenkins is 11 and 17 for recent LTS version.

So I would for for Java 17 to run plugin-modernizer action

Ok sir, Understood.

@nagu165
Copy link
Contributor

nagu165 commented Jan 10, 2025

@nagu165 : I think the question is not whether plugins will support Java 21 or not, but let me clarify a few things first. Many plugins won’t support Temurin 21 yet; we’re not ready. Jenkins core has been supporting Java 21 for a while now, and we started a campaign last year to upgrade the most installed plugins to Java 21. However, there are still many plugins that aren’t ready for Java 21, which is why we're focusing on getting them to work with Java 17 first.

Our goal in addressing this issue is to create a GitHub Action that would launch the modernizer tool. Then, the infra team could add this GitHub Action to existing plugins by default, or we could propose it through a PR to encourage maintainers to add this GitHub Action.

Yes sir, I understand the context now.
Thank you for the inputs

@jonesbusy
Copy link
Collaborator Author

@nagu165 : I think the question is not whether plugins will support Java 21 or not, but let me clarify a few things first. Many plugins won’t support Temurin 21 yet; we’re not ready. Jenkins core has been supporting Java 21 for a while now, and we started a campaign last year to upgrade the most installed plugins to Java 21. However, there are still many plugins that aren’t ready for Java 21, which is why we're focusing on getting them to work with Java 17 first.

Our goal in addressing this issue is to create a GitHub Action that would launch the modernizer tool. Then, the infra team could add this GitHub Action to existing plugins by default, or we could propose it through a PR to encourage maintainers to add this GitHub Action.

Thanks for adding more context than me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants