-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Users Documentation added #5980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BhaswatiRoy, thanks for your work on this. I have reviewed the documentation and suggested some changes for syntax and formatting. I also provided a link to the asciidoc reference that I use, as it has some helpful insight on page and text formatting.
The folder of images should be added into the content/doc/book/resources folder, as opposed to the document folder.
Co-authored-by: Kevin Martens <[email protected]>
Co-authored-by: Kevin Martens <[email protected]>
Co-authored-by: Kevin Martens <[email protected]>
Hello @kmartens27, I have accepted the suggested changes. |
Hi @BhaswatiRoy, thanks for all of the updates! it appears that there was an issue where the build failed and unfortunately, this means that the preview site is unavailable. Would you be able to update the branch and make sure that it builds fully? |
Hi @BhaswatiRoy, I was reading over the PR again, and found a few oddities. Specifically, there is no need to add the readme file. Also, I would advise against adding a separate folder for the manage users images that have been uploaded. There is an existing "managing" folder in the "resources" folder, so the images can simply be added there. I also found that the list of terms started out using the :: description list formatting, but after the first item the list changed to just being
|
Hi @BhaswatiRoy, I have some feedback/suggestions to provide and was wondering if you would be okay with me submitting the changes to the document itself as a commit? I wanted to check before making any updates so nothing is a surprise. Thanks! |
Hello @kmartens27 |
Fix: #5884