Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mirrorbits): use the PVC name defined in values.yaml everywhere #580

Merged

Conversation

lemeurherve
Copy link
Member

As it is currently, even with a repository.name value specified in values.yaml, the PVC is named only in the PVC template, it has a generic release name + "-binary" in the deployments templates.

This PR fixes that.

Note: I don't see why there are $. in front of some of the if in these deployments an in the PVC template 🤔

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

As this chart does not have any unit tests, I've tried an helmfile diff against the production cluster publick8s and the result looks good:

helmfile diff -f ./clusters/publick8s.yaml -l name=mirrorbits --suppress-secrets --skip-deps --context=2
Decrypting secret /Users/dadou/workspace/jenkins-infra/kubernetes-management/secrets/config/mirrorbits/secrets.yaml
Comparing release=mirrorbits, chart=../../helm-charts/charts/mirrorbits
mirrorbits, mirrorbits, Deployment (apps) has changed:
...
    labels:
      app.kubernetes.io/name: mirrorbits
-     helm.sh/chart: mirrorbits-0.52.2
+     helm.sh/chart: mirrorbits-0.53.0
      app.kubernetes.io/instance: mirrorbits
      app.kubernetes.io/version: "v0.5.2"
...
mirrorbits, mirrorbits, Ingress (networking.k8s.io) has changed:
...
    labels:
      app.kubernetes.io/name: mirrorbits
-     helm.sh/chart: mirrorbits-0.52.2
+     helm.sh/chart: mirrorbits-0.53.0
      app.kubernetes.io/instance: mirrorbits
      app.kubernetes.io/version: "v0.5.2"
...
mirrorbits, mirrorbits, Service (v1) has changed:
...
    labels:
      app.kubernetes.io/name: mirrorbits
-     helm.sh/chart: mirrorbits-0.52.2
+     helm.sh/chart: mirrorbits-0.53.0
      app.kubernetes.io/instance: mirrorbits
      app.kubernetes.io/version: "v0.5.2"
...
mirrorbits, mirrorbits-files, Deployment (apps) has changed:
...
    labels:
      app.kubernetes.io/name: mirrorbits
-     helm.sh/chart: mirrorbits-0.52.2
+     helm.sh/chart: mirrorbits-0.53.0
      app.kubernetes.io/instance: mirrorbits
      app.kubernetes.io/version: "v0.5.2"
...
mirrorbits, mirrorbits-files, Service (v1) has changed:
...
    labels:
      app.kubernetes.io/name: mirrorbits
-     helm.sh/chart: mirrorbits-0.52.2
+     helm.sh/chart: mirrorbits-0.53.0
      app.kubernetes.io/instance: mirrorbits
      app.kubernetes.io/version: "v0.5.2"
...

@dduportal dduportal merged commit 411415f into jenkins-infra:main Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mirrorbits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants