fix(mirrorbits): use the PVC name defined in values.yaml everywhere #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is currently, even with a
repository.name
value specified in values.yaml, the PVC is named only in the PVC template, it has a generic release name + "-binary" in the deployments templates.This PR fixes that.
Note: I don't see why there are
$.
in front of some of theif
in these deployments an in the PVC template 🤔