chore(updatecli) correct Azure VM agent controller credentials manifests #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
chore/updatecli/fix-infra.ci-azure-vm-manifest
branch
from
b1c1a09
to
848076b
Compare
dduportal
changed the title
dduportal
commented
Sep 19, 2024
updatecli/updatecli.d/fs-sp-writer-end-dates_infra.ci.jenkins.io.tf.tpl
Outdated
Show resolved
Hide resolved
dduportal
deleted the
chore/updatecli/fix-infra.ci-azure-vm-manifest
branch
This was referenced Sep 19, 2024
Closed
dduportal
added a commit
that referenced
this pull request
Sep 20, 2024
…ined (#842) Fixup of #838 and #839 We need to keep some outputs. This PR either move them or add them back but in the `outputs.tf` file which is the Terraform convention. Note: adding a comment explaining which script is using them. Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following problems:
infra.ci.jenkins.io(current end date: 2024-09-26T00:00:00Z) #822 has a wrong documentation (body)nullvalue