Skip to content
This repository has been archived by the owner on Jul 4, 2022. It is now read-only.

What's the rate limit? #4

Open
franz101 opened this issue Jan 25, 2021 · 3 comments
Open

What's the rate limit? #4

franz101 opened this issue Jan 25, 2021 · 3 comments

Comments

@franz101
Copy link

Maybe we can implement a method to avoid hitting it.

@jemorriso
Copy link
Owner

I don't know, I just figured that if people are running scripts using this library, somebody will get rate limited / IP banned. I don't know what best practices are regarding internal rate limiting of APIs... there are libraries such as ratelimit which make this easy to implement, just not sure if it's a good idea.

@jemorriso jemorriso added the help wanted Extra attention is needed label Jan 25, 2021
@jeremyjpj0916
Copy link
Contributor

jeremyjpj0916 commented Jan 27, 2021

I think possibly adding a configurable limit (defaults to no limit) would be good. So responsible engineers can set say a x calls per y seconds would be good so they don't have to focus on adding odd system timer pauses with the lib and can let the lib native handle the wait. I would go for like 1 api call every 3 seconds or something of the sort in my personal config.

Then folks who don't use it and abuse the lib/write bad code get IP banned due to their own fault 😆 .

@jemorriso
Copy link
Owner

Just saw your message. That's a good idea

@jemorriso jemorriso removed the help wanted Extra attention is needed label Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants