Hide empty message box if there isn't text #6151
Conversation
| @@ -87,7 +87,7 @@ function getEditorHtml(options, systemInfo) { | |||
| let html = ''; | |||
| html += '<div class="formDialogContent scrollY">'; | |||
| html += '<div class="dialogContentInner dialog-content-centered" style="padding-top:2em;">'; | |||
| if (!options.pathReadOnly) { | |||
| if (!options.pathReadOnly && (options.instruction || systemInfo.OperatingSystem)) { | |||
There was a problem hiding this comment.
The operating system will never be set as it was removed from the system info in 10.9:
|
Cloudflare Pages deployment
|
| "MessageDirectoryPickerBSDInstruction": "For BSD, you may need to set up storage within your 'FreeNAS Jail' so Jellyfin can access your media.", | ||
| "MessageDirectoryPickerLinuxInstruction": "For Linux on Arch Linux, CentOS, Debian, Fedora, openSUSE, or Ubuntu, you must grant the service user at least read access to your storage locations.", |
There was a problem hiding this comment.
Now that I see what these help messages should've shown, it might be worth combining these two texts into one and always displaying that? Kinda useful to have in-app help.
There was a problem hiding this comment.
Perhaps the text is too long for an info banner? Maybe we can get away with removing the mentioned distros part.
There was a problem hiding this comment.
Maybe we can have a small text and link to a (new) documentation page with a more extensive explanation?
There was a problem hiding this comment.
@viown do you still plan to update this? Thanks!
There was a problem hiding this comment.
Sure, but I'm not sure what's the appropriate documentation page to link to regarding shares permissions.
There was a problem hiding this comment.
I believe niels was suggesting creating a new page in the documentation for this.
There was a problem hiding this comment.
If someone were to create the page, I'll happily link to it. But I don't have enough knowledge about the topic to write it myself 😅
Changes
Hide the message box when there won't be text.
Issues
Fixes #6144