Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore subtitles and multiple audio that got destroyed in commit db8cd9af238813a7b141ba826168fdaa22f1509e on Feb 18, 2018 #68

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

roman-vanicek
Copy link

Subtitles and multiple audio that got destroyed in commit db8cd9a on Feb 18, 2018. Restoring probing for additional audio streams and subtitles. Tested on both live TV and recordings.

Shall fix issue Live TV - Captions not available (nor audio tracks) #63

@citronalco
Copy link
Contributor

Applied this to current master.

Subtitles:

Works perfectly for DVBSUB subtitles.
When selecting a DVBTXT subtitle, playback stops with an error:
ffmpeg output:

  Program 1 
    Metadata:
      service_name    : Das Erste HD
      service_provider: ARD
  Stream #0:0[0x13ed]: Video: h264 (High) ([27][0][0][0] / 0x001B), yuv420p(tv, bt709, progressive), 1280x720 [SAR 1:1 DAR 16:9], 50 fps, 50 tbr, 90k tbn
  Stream #0:1[0x13ee](deu): Audio: ac3 ([6][0][0][0] / 0x0006), 48000 Hz, stereo, fltp, 448 kb/s
  Stream #0:2[0x13ef](deu): Audio: ac3 ([6][0][0][0] / 0x0006), 48000 Hz, stereo, fltp, 192 kb/s (visual impaired) (descriptions)
  Stream #0:3[0x13f0](deu): Subtitle: dvb_teletext ([6][0][0][0] / 0x0006), 492x250
  Stream #0:4[0x13f1](deu): Subtitle: dvb_subtitle ([6][0][0][0] / 0x0006) (hearing impaired)
  Stream #0:5[0x13f3](deu): Audio: ac3 ([6][0][0][0] / 0x0006), 48000 Hz, stereo, fltp, 192 kb/s (hearing impaired)
  No Program
  Stream #0:6[0x12]: Data: epg
[Parsed_subtitles_2 @ 0x562bda3c3880] libass API version: 0x1703000
[Parsed_subtitles_2 @ 0x562bda3c3880] libass source: commit: 0.17.3-0-ge46aedea0a0d17da4c4ef49d84b94a7994664ab5
[Parsed_subtitles_2 @ 0x562bda3c3880] Shaper: FriBidi 1.0.15 (SIMPLE) HarfBuzz-ng 9.0.0 (COMPLEX)
[h264 @ 0x562bda69b480] non-existing PPS 0 referenced
    Last message repeated 1 times
[h264 @ 0x562bda69b480] decode_slice_header error
[h264 @ 0x562bda69b480] no frame!
[h264 @ 0x562bda69b480] mmco: unref short failure
[Parsed_subtitles_2 @ 0x562bda3c3880] Using font provider fontconfig
[Parsed_subtitles_2 @ 0x562bda3c3880] Only text based subtitles are currently supported
[AVFilterGraph @ 0x562bda3d4140] Error initializing filters
Error initializing complex filters.
Not yet implemented in FFmpeg, patches welcome

Audio channels:

Switching audio channels does not work reliable. Sometimes it works, sometimes playback continues without video, sometimes without audio, or playback does not continue at all.
When stopping playback in Jellyfin Web and selecting another TV channel, the playback issues mentioned above may also happen to the new TV channel, without having touched its audio channel at all.

@crobibero crobibero merged commit d24457c into jellyfin:master Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants