Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add an include filter option #44

Open
mcarlton00 opened this issue Apr 17, 2021 · 3 comments
Open

[Feature request] Add an include filter option #44

mcarlton00 opened this issue Apr 17, 2021 · 3 comments
Labels
feature This PR or Issue requests or introduces a new feature

Comments

@mcarlton00
Copy link
Member

The current GetItems Endpoint accepts a filter option, however it's an opt out by media type. This can lead to extra slow syncs when a user has two libraries of the same type, but only has one synced to Kodi. In the current implementation, we would receive updates for both libraries and have to sort through them locally.

In a perfect world, I'd also like to change the API response to have full items. Currently, we get a list of item IDs, but then in order to process them locally in Kodi we have to make a separate request back to the server for each item. It would be far more efficient if we could retrieve a list of all the updated items at one time. If we go this route, I think we should probably make a new endpoint that returns the full items instead of changing the existing one. Otherwise, it's going to be a pretty big change with potential to break some/most setups.

@crobibero
Copy link
Member

@mcarlton00
Copy link
Member Author

Linked issue from the Kodi repo seems to indicate that the existing plugin logic is marking things as changed when we might not care about them. Probably should be it's own issue, but since it's all part of the same overall sync issues discussion it's worth mentioning here.

@brando56894
Copy link

Any updates on this? Myself and various other users are still getting large library updates in Kodi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

No branches or pull requests

4 participants