Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelScoreTask Does Not Check For Null (like encog-dotnet-core does) #254

Open
deriven opened this issue Apr 1, 2018 · 0 comments
Open

Comments

@deriven
Copy link

deriven commented Apr 1, 2018

First of all, encog is wonderful!

When running the HyperNEAT example, gradle runNEATBoxes, from the encog-java-examples, I kept getting a NullException error. But in the .NET version, it works fine. Doing a line-by-line comparison, I found that the ParallelScoreTasks are slightly different and that the .NET version is actually better.

https://github.com/encog/encog-java-core/blob/master/src/main/java/org/encog/ml/ea/score/parallel/ParallelScoreTask.java

https://github.com/encog/encog-dotnet-core/blob/master/encog-core-cs/ML/EA/Score/Multi/ParallelScoreTask.cs

The Java version does not check for null phenotype and therefore errors later in the run method. Also the Java version traps the error and sends it to the owner which doesn't help. Whereas the .NET version skips the code if it can't get a phenotype.

Side question: which version would you think is more stable and maintained? .NET or Java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant