Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ids and lidx #449

Open
rgiordan opened this issue Dec 6, 2016 · 0 comments
Open

Fix ids and lidx #449

rgiordan opened this issue Dec 6, 2016 · 0 comments
Assignees

Comments

@rgiordan
Copy link
Contributor

rgiordan commented Dec 6, 2016

The fsm_util code uses lidx indices, even though it is used both by DeterministicVI and the LogProbability modules. This design relies on the ids parameterization and the lidx parameterization having the same indices as one another for all parameters that are touched by fsm_util.jl. Besides being brittle, we don't document what these different parameterizations mean nor that they need to overlap in this way. We also don't assert it anywhere.

A better design would be to pass a ParamType as an argument to the functions, and to refer to the ids appropriate to that type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants