Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google C++ style constant names #8

Open
JayXon opened this issue Feb 28, 2019 · 1 comment
Open

Support Google C++ style constant names #8

JayXon opened this issue Feb 28, 2019 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@JayXon
Copy link

JayXon commented Feb 28, 2019

See: https://google.github.io/styleguide/cppguide.html#Constant_Names

image
VSCode support this if not using this extension
image

@jeff-hykin jeff-hykin added the wontfix This will not be worked on label Feb 28, 2019
@jeff-hykin
Copy link
Owner

jeff-hykin commented Feb 28, 2019

So this was actually intentionally removed since it would incorrectly highlight things that were not meant to be a constant.

My friend actually pointed out a place where it was an issue:
screen shot 2019-02-28 at 6 23 07 am

Since the k syntax (along with the f) is not actually part of C++ I removed it from the default syntax highlighting.

Ideally there would be an extension to add highlighting for the the Google-Style constants since it is not highlighting that everyone wants. I'll keep this issue open for now, until I create an extension that restores those style constants. (I would just make it a setting but I don't think thats currently possible with how VS Code handles language-extensions).

There isn't even highlighting/tagging for standard library tools like cout, cin, string, vector so if C++ standard tools are not even highlighted, it doesn't make sense to highlight things that are not actually a part of C++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants