Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to test notifications #118

Closed
chuakc92 opened this issue Sep 20, 2020 · 11 comments
Closed

Unable to test notifications #118

chuakc92 opened this issue Sep 20, 2020 · 11 comments
Assignees

Comments

@chuakc92
Copy link

Description

I changed the url for certain cards as suggested to test in stock alerts, for example:

    links: [
        {
            brand: 'evga',
            model: 'xc3 black',
            url: 'https://google.com',
            oosLabels: ['out of stock']
        },

But after running the program, this file is immediately replaced. Everything was working fine this morning before I took a pull. I'm currently on commit 5b91065

Also, not sure how to fix this, but I kept getting Error: Couldn't find a suitable audio player when I was able to successfully test this morning. How do I go about fixing this? What are compatible players or do I have to do something to set one up?

@jef
Copy link
Owner

jef commented Sep 20, 2020

You're probably editing the *.js file and not the *.ts file.

@jef
Copy link
Owner

jef commented Sep 20, 2020

I'd run a npm install to get any dependencies missing.

@jef
Copy link
Owner

jef commented Sep 20, 2020

Also take a look at PLAY_SOUND to make sure you're setting the right variable.

@jef jef added the need info label Sep 20, 2020
@chuakc92
Copy link
Author

Hey Jeff, thank you for the swift response. You are right that I was setting the .js file instead. That is resolved.

I ran npm install and all I got was npm WARN [email protected] requires a peer of webpack@>=1.11.0 but none is installed. You must install dependencies yourself.

Would this cause the sound error?

Also, I received a different error when I forgot to set my PLAY_SOUND. Now that I did, it's just throwing Error: Couldn't find a suitable audio player

@jef
Copy link
Owner

jef commented Sep 20, 2020

That's interesting because that's also related to #115. We aren't using webpack, but looks like some dependency is.

I've reinstalled everything from scratch, but still haven't seen this problem. Sort of strange.

Ensure you're using the correct file: .env. Removing PLAY_SOUND shouldn't run any of the sound code.

@chuakc92
Copy link
Author

Hey Jeff,

There is only one .env file in my folder, so it's probably correct. I do intend to use PLAY_SOUND. Do you know of a way to fix this? What player are you using? Maybe I could try installing that

@jef
Copy link
Owner

jef commented Sep 20, 2020

I don't have any particular player. I think it comes with the module.

Can you take a screenshot of your output when you do npm run start and a screenshot of your directory of where nvidia-snatcher is?

@jdkennedy45
Copy link

jdkennedy45 commented Sep 20, 2020

Also getting the sound player issue.

Jake@JAKE-PC MINGW64 ~/Documents/nvidia-snatcher (main)
$ npm run test:notification

[email protected] test:notification C:\Users\Jake\Documents\nvidia-snatcher
npm run build && node build/test/notification-test.js

[email protected] build C:\Users\Jake\Documents\nvidia-snatcher
rimraf ./build && tsc

INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
[2:35:37 PM] info :: ↗ playing sound
[2:35:37 PM] error :: error playing sound: Error: Couldn't find a suitable audio player

@chuakc92
Copy link
Author

chuakc92 commented Sep 20, 2020

Jeff,

Here you go: https://imgur.com/a/iMxezEh

@kylekelso
Copy link

the mplayer still in a zip file. Do you have it elsewhere?

@jef
Copy link
Owner

jef commented Sep 20, 2020

I'm going to merge this issue with #116. Let's move discussion to there since it's the same issue.

Thanks!

@jef jef closed this as completed Sep 20, 2020
Repository owner locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants