Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support libvirt provider #26

Closed
varac opened this issue Oct 9, 2013 · 3 comments
Closed

support libvirt provider #26

varac opened this issue Oct 9, 2013 · 3 comments

Comments

@varac
Copy link

varac commented Oct 9, 2013

hi,

i'm using sahara for quite some time, it's great !
i would liek to migrate from virtualbox to libvirt, using vagrant-libvirt (https://github.com/pradels/vagrant-libvirt).
i noticed that sahara is bound to virtualbox, and i's like to know if there are plans to support libvirt.

right now, it just exits with:

vagrant sandbox on couch1
sh: 1: VBoxManage: not found
sh: 1: VBoxManage: not found
@varac
Copy link
Author

varac commented Oct 13, 2013

cool, looks like sciurus is working on support for vagrant-libvirt to sahara, see https://github.com/sciurus/sahara/commits/abstract_provider (and vagrant-libvirt/vagrant-libvirt#73 (comment)).

@sciurus
Copy link
Contributor

sciurus commented Oct 13, 2013

I have a version of sahara at sciurus/sahara/tree/abstract_provider where I've reworked sahara's "session" implementation. I moved the generic logic into the commands themselves, keeping (mostly) just the virtualbox-specific code in the session. Instead of always loading support for virtualbox, I check the provider in use for each machine and try to load a session class that supports it.

@jedi4ever Comments on my approach and any changes you'd like to see would be highly appreciated.

I'm just getting started on writing a class that adds support for libvirt. I'll push another branch with it when it's working.

@ryuzee
Copy link
Collaborator

ryuzee commented May 29, 2014

libvirt provider was already merged so that we can close this issue.

@ryuzee ryuzee closed this as completed May 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants