Various fixes, proper Typed Racket support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I do know how to get the errors to span the correct text instead of just being on the left parens, but I'm out of time for today. I'll add it in tomorrow and then this will be ready for merge. |
|
This looks like great progress |
|
Ok, this is good to go now.
|
|
Awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30, Fixes #28, Fixes #12
I don't really know if there's a more "correct" way to catch the typed racket errors, but they weren't being caught by all the existing handlers and all I came up with by spelunking drracket and typed-racket repositories was to intercept logs and nab them that way.
Handling the #lang lines a little nicer has lovely side effects, such as properly reporting when a module is missing instead of the langserver just going into an unusable state.