Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare against vscode #39

Open
jeancroy opened this issue Apr 2, 2018 · 0 comments
Open

compare against vscode #39

jeancroy opened this issue Apr 2, 2018 · 0 comments

Comments

@jeancroy
Copy link
Owner

jeancroy commented Apr 2, 2018

Ensure that we pass score quality issues raised against vscode (in addition to atom)

See test suite here:
https://github.com/Microsoft/vscode/blob/master/src/vs/base/test/common/filters.test.ts

And implementation here:
https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/filters.ts

In particular see test with actual issue number next to it ( real life scenario )
Also check character per character highlight test, which we mostly lack beside very easy test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant