You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm considering whether mise doctor should error or not if mise has not been activated (or shims have been added to PATH).
Here's my argument for keeping the warning:
Generally speaking, users use mise for the tools functionality and not understanding that they need to set it up with activation/shims is almost certainly going to be the most common step they miss. Users may not read the docs at all, just attempt to install mise by some method and get confused that it does not work.mise doctor provides at least a way that if they try to submit a ticket, the ticket instructions will tell them to run mise doctor and they will then know they missed that step. I suspect a lot of users probably do this today—though I don't know about it because they never actually fill the ticket out so that's kind of an educated guess.
Here's my argument for getting rid of it:
Users may not use the tools functionality and instead only use mise for env vars and/or tasks so the fact it has not been activated is irrelevant. Also, there are ways to use mise (via mise env, mise exec, or mise run) where you never need to activate. In fact, this is how I use mise myself and quite like using it in this way since it keeps my shell cleaner. Displaying this as a "problem" is just giving users a red herring that may not be relevant to the way they use the tool.
I considered making it just a warning that doesn't cause mise doctor to return nonzero but I'm not sure that really helps the issue much.
Anyone have any thoughts here? This is a tough spot to know what to do. Right now I think I'm leaning towards keeping it but thought it was worth a discussion.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm considering whether
mise doctor
should error or not if mise has not been activated (or shims have been added to PATH).Here's my argument for keeping the warning:
Generally speaking, users use mise for the tools functionality and not understanding that they need to set it up with activation/shims is almost certainly going to be the most common step they miss. Users may not read the docs at all, just attempt to install mise by some method and get confused that it does not work.
mise doctor
provides at least a way that if they try to submit a ticket, the ticket instructions will tell them to runmise doctor
and they will then know they missed that step. I suspect a lot of users probably do this today—though I don't know about it because they never actually fill the ticket out so that's kind of an educated guess.Here's my argument for getting rid of it:
Users may not use the tools functionality and instead only use mise for env vars and/or tasks so the fact it has not been activated is irrelevant. Also, there are ways to use mise (via
mise env
,mise exec
, ormise run
) where you never need to activate. In fact, this is how I use mise myself and quite like using it in this way since it keeps my shell cleaner. Displaying this as a "problem" is just giving users a red herring that may not be relevant to the way they use the tool.I considered making it just a warning that doesn't cause
mise doctor
to return nonzero but I'm not sure that really helps the issue much.Anyone have any thoughts here? This is a tough spot to know what to do. Right now I think I'm leaning towards keeping it but thought it was worth a discussion.
Beta Was this translation helpful? Give feedback.
All reactions