From bdda43b2621811c3d28e2da1b9cf0f63d425380b Mon Sep 17 00:00:00 2001 From: Max Grossman Date: Wed, 5 Feb 2020 12:00:01 -0600 Subject: [PATCH] Clarify behavior of shmem_sync, shmem_broadcast, shmem_reduction, shmem_alltoall(s), shmem_collect when passed invalid team --- content/shmem_alltoall.tex | 2 ++ content/shmem_broadcast.tex | 5 ++--- content/shmem_collect.tex | 2 ++ content/shmem_reductions.tex | 5 +++-- content/shmem_sync.tex | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/content/shmem_alltoall.tex b/content/shmem_alltoall.tex index 1a51da719..b1d61489b 100644 --- a/content/shmem_alltoall.tex +++ b/content/shmem_alltoall.tex @@ -94,6 +94,8 @@ Team-based collect routines operate over all \acp{PE} in the provided team argument. All \acp{PE} in the provided team must participate in the collective. + If \VAR{team} compares equal to \LibConstRef{SHMEM\_TEAM\_INVALID} or is + otherwise invalid, the behavior is undefined. Active-set-based collective routines operate over all \acp{PE} in the active set defined by the \VAR{PE\_start}, \VAR{logPE\_stride}, \VAR{PE\_size} triplet. diff --git a/content/shmem_broadcast.tex b/content/shmem_broadcast.tex index 66a98f28c..508756bc4 100644 --- a/content/shmem_broadcast.tex +++ b/content/shmem_broadcast.tex @@ -74,9 +74,8 @@ \item The \dest{} object is updated on all \acp{PE}. \item All \acp{PE} in the \VAR{team} argument must participate in the operation. - \item If an invalid team handle or - \LibConstRef{SHMEM\_TEAM\_INVALID} is passed to this routine, - the behavior is undefined. + \item If \VAR{team} compares equal to \LibConstRef{SHMEM\_TEAM\_INVALID} or is + otherwise invalid, the behavior is undefined. \item \ac{PE} numbering is relative to the team. The specified root \ac{PE} must be a valid \ac{PE} number for the team, between \CONST{0} and \VAR{N$-$1}, where \VAR{N} is the size of diff --git a/content/shmem_collect.tex b/content/shmem_collect.tex index a9b79cc6d..2d7dbea9d 100644 --- a/content/shmem_collect.tex +++ b/content/shmem_collect.tex @@ -85,6 +85,8 @@ Team-based collect routines operate over all \acp{PE} in the provided team argument. All \acp{PE} in the provided team must participate in the operation. + If \VAR{team} compares equal to \LibConstRef{SHMEM\_TEAM\_INVALID} or is + otherwise invalid, the behavior is undefined. Active-set-based collective routines operate over all \acp{PE} in the active set defined by the \VAR{PE\_start}, \VAR{logPE\_stride}, \VAR{PE\_size} triplet. diff --git a/content/shmem_reductions.tex b/content/shmem_reductions.tex index 02ab0e8d8..f8b85dd01 100644 --- a/content/shmem_reductions.tex +++ b/content/shmem_reductions.tex @@ -248,8 +248,9 @@ completely disjoint. Team-based reduction routines operate over all \acp{PE} in the provided team argument. All - \acp{PE} in the provided team must participate in the reduction. If an invalid team handle - or \LibConstRef{SHMEM\_TEAM\_INVALID} is passed to this routine, the behavior is undefined. + \acp{PE} in the provided team must participate in the reduction. + If \VAR{team} compares equal to \LibConstRef{SHMEM\_TEAM\_INVALID} or is + otherwise invalid, the behavior is undefined. Active-set-based sync routines operate over all \acp{PE} in the active set defined by the \VAR{PE\_start}, \VAR{logPE\_stride}, \VAR{PE\_size} triplet. diff --git a/content/shmem_sync.tex b/content/shmem_sync.tex index 4cd7ce8ee..b53bf3edb 100644 --- a/content/shmem_sync.tex +++ b/content/shmem_sync.tex @@ -49,8 +49,8 @@ Team-based sync routines operate over all \acp{PE} in the provided team argument. All \acp{PE} in the provided team must participate in the sync operation. - If an invalid team handle or \LibConstRef{SHMEM\_TEAM\_INVALID} - is passed to this routine, the behavior is undefined. + If \VAR{team} compares equal to \LibConstRef{SHMEM\_TEAM\_INVALID} or is + otherwise invalid, the behavior is undefined. Active-set-based sync routines operate over all \acp{PE} in the active set defined by the \VAR{PE\_start}, \VAR{logPE\_stride}, \VAR{PE\_size} triplet.